Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some completion tests #12908

Merged
merged 3 commits into from
May 23, 2024
Merged

Conversation

WindSoilder
Copy link
Collaborator

@WindSoilder WindSoilder commented May 19, 2024

Description

 ls
╭───┬───────┬──────┬──────┬──────────╮
 # │ name  │ type │ size │ modified │
├───┼───────┼──────┼──────┼──────────┤
 0  a.txt  file   0 B  now      
╰───┴───────┴──────┴──────┴──────────╯

 ls a.
NO RECORDS FOUND

There is a completion issue on previous version, I think @amtoine have reproduced it before. But currently I can't reproduce it on latest main.
To avoid such regression, I added some tests for completion.

Copy link
Member

@amtoine amtoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm trying it out on latest main... ♻️
could definitely reproduce on 0.93.0 at least

EDIT: yep, appears to be fixed on latest main, having a regression test sounds perfect 🙏

crates/nu-cli/tests/completions/mod.rs Outdated Show resolved Hide resolved
Co-authored-by: Antoine Stevan <44101798+amtoine@users.noreply.github.com>
@sholderbach
Copy link
Member

I think related are:

@sholderbach sholderbach added the tests issues to add tests or fix tests label May 20, 2024
@WindSoilder WindSoilder merged commit 58cf0c5 into nushell:main May 23, 2024
13 checks passed
@WindSoilder WindSoilder deleted the completion_tests branch May 23, 2024 02:57
@hustcer hustcer added this to the v0.94.0 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests issues to add tests or fix tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants