Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Reintroduce macOS font size hack #10660

Closed
wants to merge 1 commit into from

Conversation

gxalpha
Copy link
Member

@gxalpha gxalpha commented May 10, 2024

Description

eea0e3d (part of #9653) removed the equivalent of this as part of the theming overhaul but didn't provide a replacement (or other reasoning), resulting in text being tiny again. Let's add this back, at least until a proper solution is found.

Motivation and Context

Don't want tiny text.
There has been chatter about potentially adding OS-specific variables or something to the theming system. This however hasn't happened and since we're already in the deps updating phase it's likely it isn't happening. I don't want to have a beta ship with the tiny text so lets just re-add the hack.

How Has This Been Tested?

macOS 14.4.1

See the screenshot of this PR vs current master vs OBS 30.1 (for reference).

This PR: Bildschirmfoto 2024-05-10 um 20 38 31 Current master branch: Bildschirmfoto 2024-05-10 um 20 37 51 30.1: Bildschirmfoto 2024-05-10 um 20 36 34

Also went through the program (in particular: Settings, About Dialog, Source Properties, Advanced Audio Properties) to confirm nothing else exploded.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

eea0e3d removed the equivalent of this
as part of the theming overhaul but didn't provide a replacement,
resulting in text being tiny again. Let's add this back, at least until
a proper solution is found.
@gxalpha gxalpha added Bug Fix Non-breaking change which fixes an issue macOS Affects macOS labels May 10, 2024
@gxalpha gxalpha requested a review from PatTheMav May 10, 2024 18:54
@Warchamp7 Warchamp7 mentioned this pull request May 10, 2024
6 tasks
@gxalpha gxalpha deleted the the-hack-returns branch May 14, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue macOS Affects macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant