Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libobs/util: Add buffered file serializer #10671

Merged
merged 1 commit into from May 18, 2024

Conversation

derrod
Copy link
Member

@derrod derrod commented May 13, 2024

Description

Adds a buffered file serializer, essentially porting the feature added in #5717 to the libobs utilities and serializer API.

Motivation and Context

See #5717 for the reasons of wanting a buffered writer.

As the existing one is only in the ffmpeg muxer binary, but I also needed it for the native MP4 muxer, I figured it'd be good to make it available via the generic OBS serializer API so it can be reused in other components if it makes sense to do so. For example, we may consider also using it in the native FLV output.

Split out from #10608 for easier review and slimming down that PR as things get merged.

How Has This Been Tested?

Tested as part of #10608.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@derrod derrod added the Enhancement Improvement to existing functionality label May 13, 2024
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay at a glance. Left some questions/nits.

docs/sphinx/reference-libobs-util-serializers.rst Outdated Show resolved Hide resolved
libobs/util/buffered-file-serializer.c Outdated Show resolved Hide resolved
libobs/util/buffered-file-serializer.c Outdated Show resolved Hide resolved
Adapted from 898256d

Co-authored-by: Richard Stanway <r1ch@r1ch.net>
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay at a glance now.

@Lain-B Lain-B merged commit 89c7a96 into obsproject:master May 18, 2024
15 checks passed
@derrod derrod deleted the buffered-file-serializer branch May 18, 2024 23:15
@RytoEX RytoEX added this to the OBS Studio (Next Version) milestone May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants