change all smart quotes, worth a thorough review #118
Conversation
|
if we merge this, will other PRs by @synesthete get clobbered? I'm happy also to do this after his PRs are merged, since this is a pretty easy to do change and I'd rather not mess with all the great copy editing.... |
|
Nice - thanks for adding the curly quote removal. 44f3b46 caught some things that would definitely have broken pandoc. Yeah it seems like it would be safer to get @synesthete's PRs into the chapters first. |
|
ok I emailed authors individually to take a look, and I'm happy to run the same steps again (it's pretty simple to do / check) once more of the PRs are merged. |
|
great - thanks for doing that |
|
I merge all of @synesthete PRs, will took a look at this issue now. |
|
Hello @tpltnt @bilderbuchi, what's the status on this PR? is it obsolete and can be closed or does it need more work? |
|
I honestly have no idea... |
|
;) @tpltnt @ofZach @mikewesthad do you think it make sense to close it? It has ~3 years and I doubt we will have time to check the conflict files 1 by 1, probably some of these things went fixed in other PRs. What do you think? |
|
@edap Seems to me that we could close this PR and someone could open a new one after rerunning the sed / find & replace to get rid off curly quotes? |
rich diff might help to make this easier to see.
I basically did a find an replace on all smart single quotes. I figure it will help us standardize things and we can use a javascript / other approach to displaying smart quotes.