Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating list of core addons #182

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

tpltnt
Copy link
Collaborator

@tpltnt tpltnt commented Feb 21, 2016

Hi there,

I updated the list of core addons as pointed out in #177.

Cheers,
tpltnt

@tpltnt
Copy link
Collaborator Author

tpltnt commented Apr 17, 2016

ping

@arturoc
Copy link
Member

arturoc commented Apr 17, 2016

hey, thanks but not sure if ofxAndroid, ofxiOS, ofxEmscripten and ofxUnitTests should be mentioned at all. ofxUnitTests is not even included in the download and the rest are not meant to be used as normal addons but get automatically included when compiling for the specific platform

@tpltnt
Copy link
Collaborator Author

tpltnt commented Apr 17, 2016

This PR is to address the (now) non-existent addons, as mentioned in #177

@tpltnt
Copy link
Collaborator Author

tpltnt commented Apr 22, 2016

ping

@tpltnt
Copy link
Collaborator Author

tpltnt commented May 25, 2016

ping

@tpltnt
Copy link
Collaborator Author

tpltnt commented Oct 30, 2016

@arturoc the context is about the core addons, not whether or not they should/need to be used.

@tpltnt
Copy link
Collaborator Author

tpltnt commented Oct 30, 2016

This PR lingers for more than half a years for no good reason. It should either be merged or closed. #177 should be addressed if this PR is not found suitable.

@ofZach
Copy link
Contributor

ofZach commented Oct 30, 2016

I don't think arturo's comments have been addressed. I am not sure it's helpful to consider something like ofxIos in the same list as something like ofxOsc, since they can't be used in the same way. One is used automatically to extend OF per platform (with no user control) the other is a choice in the project generator, etc.

@tpltnt
Copy link
Collaborator Author

tpltnt commented Oct 30, 2016

I removed the remarks on removed ofxiOS, ofxAndroid, ofxEmscripten and ofxUnitTests.

@edap
Copy link
Member

edap commented Oct 25, 2018

@tpltnt is this PR still actual?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants