Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ofMesh - newfaces push_back to insert a list #7772

Merged
merged 5 commits into from
May 17, 2024

Conversation

dimitre
Copy link
Member

@dimitre dimitre commented Nov 23, 2023

Splitting from more complex PR #7493

@dimitre dimitre marked this pull request as draft November 23, 2023 16:40
@ofTheo
Copy link
Member

ofTheo commented Nov 28, 2023

looks like issues with the changes - in the VS action:

  ofMesh.inl(2210,5): error C2398: Element '2': conversion from 'unsigned __int64' to '_Ty' requires a narrowing conversion 
  ofMesh.inl(2211,5): error C2398: Element '3': conversion from 'unsigned __int64' to '_Ty' requires a narrowing conversion 
  ofMesh.inl(2213,5): error C2398: Element '5': conversion from 'unsigned __int64' to '_Ty' requires a narrowing conversion 
  ofMesh.inl(2214,5): error C2398: Element '6': conversion from 'unsigned __int64' to '_Ty' requires a narrowing conversion 
  ofMesh.inl(2216,5): error C2398: Element '8': conversion from 'unsigned __int64' to '_Ty' requires a narrowing conversion 
  ofMesh.inl(2217,5): error C2398: Element '9': conversion from 'unsigned __int64' to '_Ty' requires a narrowing conversion 
  ofMesh.inl(2218,5): error C2398: Element '10': conversion from 'unsigned __int64' to '_Ty' requires a narrowing conversion 
  ofMesh.inl(2219,5): error C2398: Element '11': conversion from 'unsigned __int64' to '_Ty' requires a narrowing conversion 
  ofMesh.inl(2220,5): error C2398: Element '12': conversion from 'unsigned __int64' to '_Ty' requires a narrowing conversion 

@dimitre dimitre marked this pull request as ready for review May 16, 2024 18:20
@dimitre
Copy link
Member Author

dimitre commented May 16, 2024

Finally all fixed. and I've updated some sqrt to std::sqrt also

@ofTheo ofTheo merged commit e9d562f into openframeworks:master May 17, 2024
11 checks passed
@dimitre dimitre deleted the newfaces branch May 17, 2024 13:28
danoli3 added a commit to danoli3/openFrameworks that referenced this pull request May 20, 2024
…leedingmacOS

* commit '7f37e70f65e9e022ba8868fb555570ce2c78a6ba': (37 commits)
  Allows Retina hi res enabled via App or Project.xcconfig (openframeworks#7971)
  actions changes (openframeworks#7968)
  Changing exr to hdr files for compatability with windows (openframeworks#7964)
  ofMesh - newfaces push_back to insert a list (openframeworks#7772)
  restore default-copy-constructibility of ofEvent (openframeworks#7969)
  [actions] ccache update (openframeworks#7967)
  Core small changes (openframeworks#7952)
  config.emscripten.default.mk for Emscripten >= 3.1.52 (openframeworks#7909)
  Fix edge case in findDelimiter (openframeworks#7911)
  oscpack / udpSocket: invert the "break_" semaphore (openframeworks#7963)
  ofxOscMessage: extra implicit adds [fixes something noted through openframeworks#7938 debugging] (openframeworks#7953) #changelog #ofxOsc
  ofThreadChannel::clear() to clear the channel (openframeworks#7921) #changelog #threadChannel
  OfxOscReceiver: from detach() to join() (openframeworks#7949)
  Update ofMathConstants.h (openframeworks#7958)
  [actions] update ubuntu 24.04 (openframeworks#7955)
  ofScopedMatrix (openframeworks#7946)
  [actions] - testing one action with multiple jobs for tests (openframeworks#7860)
  adding of.entitlements and vscode files to gitignore (openframeworks#7031)
  Make - use relative paths (openframeworks#7519)
  FPS timing with chrono (openframeworks#7867)
  ...

# Conflicts:
#	libs/openFrameworks/sound/ofAVEngineSoundPlayer.mm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants