-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
installer: mount /product for non dynamic devices as well #868
Conversation
* As we dont mount /product for devices that are not dynamic and have a separate partition, on such devices AOSP counterpart apps in /product end up not being removed, among possibly other similar issues as well. * So mount it. Thanks to @nikhilmenghani for the tip
(Just so that we're clear) Verified on:
|
Hold, while I do a follow up change for addon.d |
Hi, thanks for your PR! |
Makes sense, I guess! |
So I wait for a merge until addon.d is also updated? |
addon.d will be tricky, I'm not even sure if/how we handle /vendor there currently |
Yes, that would be ideal.
Indeed. I didnt see anything to handle /vendor. This was what i came up with then, it was working on non dynamic. But the dynamic one was screwing up and aborting the install when i dirty flashed. Not sure why, right now. If we do manage to get it working somehow, might as well extend to it mount vendor as well (if needed). |
So probably better to just merge this and have addon.d on a to-do list for later.. I'm thinking if we can get things mounted right then removals should be able to happen via the normal addon.d functions since it's all symlinked into /system. But on dynamic, most importantly on A/B devices with addon.d-v2, those extra mounts will need to be into /postinstall, and are not standard to do, so it'll be pretty tricky. |
Alright then. Guess it makes sense to merge this. |
Alright, thanks! |
Let's track the addon.d issue here |
As we dont mount /product for devices that are not dynamic
and have a separate partition, on such devices AOSP counterpart
apps in /product end up not being removed, among possibly other
similar issues as well.
So mount it.
Thanks to @nikhilmenghani for the tip