Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RegularShape cache #15169

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

RegularShape cache #15169

wants to merge 4 commits into from

Conversation

MoonE
Copy link
Contributor

@MoonE MoonE commented Sep 24, 2023

Fixes #15147
Missing some test, but seems to be working ...

  • Caching gradients and patterns is done by putting those in a WeakMap with an id (could also be a getUid call).
  • There's an inconsistency for the declutter mode properties. For icons it was 'declutter', for shapes 'declutter-mode'

@MoonE MoonE force-pushed the regularshape-cache branch 2 times, most recently from 3956bea to 9805edb Compare September 25, 2023 21:14
@github-actions
Copy link

📦 Preview the website for this branch here: https://deploy-preview-15169--ol-site.netlify.app/.

@ahocevar
Copy link
Member

ahocevar commented Nov 7, 2023

@MoonE Thanks for your work on this! Is there anything I can help with to get this ready for review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon cache for RegularShapes
2 participants