Test on Ubuntu 24.04 and Qt 6 #5144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcovr 7.0, packaged in Ubuntu 24.04 Universe, fails to parse large coverage files.
kintel
reviewed
May 19, 2024
| os: [ ubuntu-20.04, ubuntu-22.04 ] | ||
| os: [ ubuntu-20.04, ubuntu-22.04, ubuntu-24.04 ] | ||
| qt: [ qt5, qt6 ] | ||
| exclude: |
There was a problem hiding this comment.
Why do we exclude these? A comment explaining why and if applicable when it can be turned back on would be great
There was a problem hiding this comment.
Commit added with comments:
@@ -16,8 +16,10 @@ jobs:
qt: [ qt5, qt6 ]
exclude:
- os: ubuntu-20.04
+ # Qt 6 not packaged
qt: qt6
- os: ubuntu-22.04
+ # libqscintilla2-qt6-dev not packaged
qt: qt6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tidying up of github-ci-linux-get-dependencies.sh and its use with old and misnamed Ubuntus and an attempt to avoid similar problems in future by defaulting to ubuntu-latest (although that still does have to be defined in one place).
gcovr completes, but the reports show no coverage - which actually isn't any different to the existing tests on other PRs as far as I can see.
gcovr -r ../srcdoes seem an improvement ongcovr -r ..in that it doesn't collect source files from the build directory or submodules.