-
-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed console logs to error or info (not a lot) #1925
base: master
Are you sure you want to change the base?
Conversation
Linked to this issue, but I don't know how to link issues. |
@athammana If you could please resolve the merge conflicts we can get this landed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one issue. Also the build is failing for this PR, but it may be because of the same issue, so let's start with that!
@@ -2294,7 +2294,25 @@ function OpenSeadragon( options ){ | |||
|
|||
request.send(null); | |||
} catch (e) { | |||
$.console.log( "%s while making AJAX request: %s", e.name, e.message ); | |||
var msg = e.message; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe all of this IE code has been removed on master, so I think it's being mistakenly added back here (due to a merge conflict). Would you agree, @msalsbery ?
I think this whole section simply needs to become :
$.console.error( "%s while making AJAX request: %s", e.name, e.message );
@athammana can you make that change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iangilman Yeah weird it doesn't show conflict, but master should definitely be merged into athammana:master ...there's code right below there that's now gone
Hi! This is my first ever issue so let me know if I did anything wrong or messed anything up! Also there were a couple of console logs I left in navigator.js module for tests because they were behind a debug flag.