-
-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the flipping of the primary mouse button #2258
base: master
Are you sure you want to change the base?
Conversation
Thank you for getting this rolling! For reference, this is where this feature was discussed: I'm still feeling like we would be better off adding a Does that make sense? |
Yeah I get that. Amusingly once I pulled the fork into my own project I realized all my To follow up, part of my issue personally is that |
Good point! Yes, please add a |
@geoff-harper Happy new year! Are you still interested in working on this patch? |
Hey apologies I've been away. Yes I'd like to get this working but I haven't had the time lately and I'll be fairly busy through January. If someone else wanted to take it from here that would be fine since I don't want to hold up a release or anything, but I will come back and finish it otherwise |
@geoff-harper Okay, great to know! We'll see if anyone else picks it up. Otherwise, see you in February :) |
I'm looking into taking this - see comment here |
@geoff-harper I'll take this on if you're cool with that. If so, can I just take over your branch or should I make a new one? cc @iangilman |
Sure @msalsbery, sorry I got caught up in other things and I'm currently away for a month or so. Let me know what you need |
Cool, thank you - no problem. I'll work from your pr/2258 branch (I think...I'll post here if I start from a fresh branch) The handling of alternate buttons by MouseTracker hasn't really changed since way back pre-v2 so I need to go through and bring it up-to-date with the W3C Pointer Events model so it's a bit more involved than just using the existing events ;) |
Hey I've finally had some time to go through and give this a swing. I decided to treat it the same as the click threshold values on the Mousetracker class since that made the most sense to me. Let me know if there are any convention things you'd like me to change.
There's the question of what to do with the context menu. Currently when you flip nothing is done about it so it opens after every pan. I wasn't sure if this is something we're concerned with or if it should be resolved in userland
As an aside, I went down a bit of a rabbit hole with
isPrimary
andgetIsPrimary
to eventually discover they don't really do anything. I've left them alone since there's a good chance I'm misinterpreting what they're for.