Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is a memory leak defect on line 134 of /openssl/test/threadpool_test.c. #24104

Closed
LuMingYinDetect opened this issue Apr 11, 2024 · 0 comments
Closed

There is a memory leak defect on line 134 of /openssl/test/threadpool_test.c. #24104

LuMingYinDetect opened this issue Apr 11, 2024 · 0 comments
Labels
branch: master Merge to master branch branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 triaged: bug The issue/pr is/fixes a bug

Comments

@LuMingYinDetect
Copy link

1.On line 103 of the file /openssl/test/threadpool_test.c, a pointer variable named 'cust_ctx' is defined and dynamic memory is allocated for it through the function OSSL_LIB_CTX_new. When the if statement on line 133 returns true, the program will return on line 134, thereby bypassing the release operation on the dynamic memory area pointed to by the 'cust_ctx' pointer on line 239. This constitutes a memory leak defect, as shown in the diagram below:
https://github.com/LuMingYinDetect/openssl_defects/blob/main/openssl_10.png
@LuMingYinDetect LuMingYinDetect added the issue: bug report The issue was opened to report a bug label Apr 11, 2024
@nhorman nhorman added the triaged: bug The issue/pr is/fixes a bug label Apr 11, 2024
coolshrid added a commit to coolshrid/openssl that referenced this issue Apr 28, 2024
@coolshrid
Fixes openssl#24104, added a goto label for cleanup
858a77d
coolshrid added a commit to coolshrid/openssl that referenced this issue Apr 28, 2024
@coolshrid
Fixes openssl#24104, added a goto label for cleanup
9e5ff31
@t8m t8m added branch: master Merge to master branch branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 and removed issue: bug report The issue was opened to report a bug labels Apr 29, 2024
coolshrid added a commit to coolshrid/openssl that referenced this issue Apr 30, 2024
@coolshrid
Fixes openssl#24104, added a goto label for cleanup
a1f178d
@coolshrid coolshrid mentioned this issue May 16, 2024
Closed
openssl-machine pushed a commit that referenced this issue May 22, 2024
@coolshrid @t8m
Fix mem leak in threadpool_test.c
52313d3 
Fixes #24104

Added a goto label for cleanup.

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #24412)

(cherry picked from commit 4dbd492)
openssl-machine pushed a commit that referenced this issue May 22, 2024
@coolshrid @t8m
Fix mem leak in threadpool_test.c
2e5f297 
Fixes #24104

Added a goto label for cleanup.

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #24412)

(cherry picked from commit 4dbd492)
jvdsn pushed a commit to jvdsn/openssl that referenced this issue Jun 3, 2024
@coolshrid @jvdsn
Fix mem leak in threadpool_test.c
d97c3e7 
Fixes openssl#24104

Added a goto label for cleanup.

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#24412)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch: master Merge to master branch branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 triaged: bug The issue/pr is/fixes a bug
Projects
Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix mem leak in threadpool_test.c coolshrid/openssl
3 participants
@nhorman @t8m @LuMingYinDetect