Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mem leak in threadpool_test.c #24412

Closed
wants to merge 1 commit into from
Closed

Fix mem leak in threadpool_test.c #24412

wants to merge 1 commit into from

Conversation

coolshrid
Copy link
Contributor

@coolshrid coolshrid commented May 15, 2024 •
edited by t8m

Fixes #24104

@t8m
Copy link
Member

t8m commented May 16, 2024

Please drop the merge commits. git reset --hard HEAD~~~; git push --force should help.

@t8m t8m added branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug tests: exempted The PR is exempt from requirements for testing branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 labels May 16, 2024
@coolshrid coolshrid marked this pull request as ready for review May 16, 2024 23:23
@coolshrid
Copy link
Contributor Author

Done

@coolshrid
Copy link
Contributor Author

coolshrid commented May 16, 2024 via email

@paulidale paulidale added the approval: review pending This pull request needs review by a committer label May 16, 2024
@t8m t8m changed the title Fixes #24104 Fix mem leak in threadpool_test.c May 17, 2024
@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels May 17, 2024
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels May 18, 2024
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m
Copy link
Member

t8m commented May 20, 2024

Merged to the master, 3.3 and 3.2 branches with reworded commit message. Thank you for your contribution.

@t8m t8m closed this May 20, 2024
openssl-machine pushed a commit that referenced this pull request May 22, 2024
@coolshrid @t8m
Fix mem leak in threadpool_test.c
52313d3 
Fixes #24104

Added a goto label for cleanup.

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #24412)

(cherry picked from commit 4dbd492)
openssl-machine pushed a commit that referenced this pull request May 22, 2024
@coolshrid @t8m
Fix mem leak in threadpool_test.c
2e5f297 
Fixes #24104

Added a goto label for cleanup.

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #24412)

(cherry picked from commit 4dbd492)
openssl-machine pushed a commit that referenced this pull request May 22, 2024
@coolshrid @t8m
Fix mem leak in threadpool_test.c
4dbd492 
Fixes #24104

Added a goto label for cleanup.

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #24412)
jvdsn pushed a commit to jvdsn/openssl that referenced this pull request Jun 3, 2024
@coolshrid @jvdsn
Fix mem leak in threadpool_test.c
d97c3e7 
Fixes openssl#24104

Added a goto label for cleanup.

Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#24412)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@paulidale paulidale paulidale approved these changes

@shahsb shahsb shahsb approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.2 Merge to openssl-3.2 branch: 3.3 Merge to openssl-3.3 tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There is a memory leak defect on line 134 of /openssl/test/threadpool_test.c.
5 participants
@coolshrid @t8m @openssl-machine @paulidale @shahsb