Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: separate yurt-manager clients #2051

Merged

Conversation

luc99hen
Copy link
Member

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Propose a plan for separating yurt-manager clients.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.61%. Comparing base (2154da8) to head (de14443).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2051      +/-   ##
==========================================
- Coverage   55.62%   55.61%   -0.01%     
==========================================
  Files         186      186              
  Lines       18072    18079       +7     
==========================================
+ Hits        10052    10055       +3     
- Misses       6995     7001       +6     
+ Partials     1025     1023       -2     
Flag Coverage Δ
unittests 55.61% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luc99hen luc99hen force-pushed the proposal/seperate-yurtmanager-client branch from 1e5483d to 99effe5 Compare May 20, 2024 07:55
@rambohe-ch
Copy link
Member

@luc99hen Thank you for raising proposal to improve rbac management of yurt-manager component. and this proposal will reduce the security risk of OpenYurt cluster. moreover, it is easy for users to track the source controller that apply request to kube-apiserver.

I am looking forward to your code pull request.

@rambohe-ch
Copy link
Member

@luc99hen At the same time, I think you can make a share presentation on the community meeting this week.

@luc99hen luc99hen force-pushed the proposal/seperate-yurtmanager-client branch from 99effe5 to de14443 Compare May 23, 2024 07:55
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@rambohe-ch rambohe-ch added approved approved lgtm lgtm labels May 23, 2024
@rambohe-ch rambohe-ch merged commit e4740ba into openyurtio:master May 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants