Add functionality for normal users to view the full data of /servers.json #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…json This patch provides the functionality of allowing certain accounts to view the full output of /servers.json, including server administrators. Previously, the only users which could view this data in full were sysadmins, which does not comply with the least privilege principle of security (they are able to make changes to keys, while only needing to view read-only data).
Dusty7401
approved these changes
Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch provides the functionality of allowing certain accounts to view the full output of /servers.json, including server administrators.
Previously, the only users which could view this data in full were sysadmins, which does not comply with the least privilege principle of security (they are able to make changes to keys, while only needing to view read-only data).