lucene 9.10.0 #4570
Draft
lucene 9.10.0 #4570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
tarzanek
commented
Apr 23, 2024
| public BitIntsHolder reduce(Collection<SuggestResultCollector> collectors) { | ||
| BitIntsHolder reduced = documentIds; | ||
| for (SuggestResultCollector collector : collectors) { | ||
| documentIds.or(collector.documentIds); //TODO fix as per https://github.com/apache/lucene/pull/766/files |
|
seems SuggestResultCollector.java has no testing coverage ... |
|
@ahornace any clues for proper fixing of reduce for that collector? Is it even used? |
tarzanek
commented
Apr 24, 2024
| @@ -205,18 +205,17 @@ private void searchMultiDatabase(List<Project> projectList, boolean paging) thro | |||
| } | |||
|
|
|||
| private void searchIndex(IndexSearcher searcher, boolean paging) throws IOException { | |||
| collector = TopScoreDocCollector.create(hitsPerPage * cachePages, Short.MAX_VALUE); | |||
| collectorManager = new TopScoreDocCollectorManager(hitsPerPage * cachePages, Short.MAX_VALUE); | |||
There was a problem hiding this comment.
perhaps redesign to reuse the object?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.