Use postgresql flexible server #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
edburns
approved these changes
Jun 4, 2024
rjeberhard
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the GitHub Actions workflows and related files to improve the setup of the PostgreSQL database and to simplify the codebase. The most important changes include creating a new GitHub Action for setting up a PostgreSQL Flexible Server, removing unnecessary steps in the workflows, and modifying the workflows to use the new action.
GitHub Action creation:
.github/actions/createPostgresqlFlexibleServer/action.yml: Created a new GitHub Action for setting up a PostgreSQL Flexible Server. This action takes several inputs, including the database admin user, database name, password, server name, location, and resource group name. It uses theaz postgres flexible-server createcommand to set up the server and theaz postgres flexible-server firewall-rule createcommand to allow access from Azure services.Workflow simplification:
.github/workflows/setupWlsAksDependency.yml,.github/workflows/testWlsAksWithDependencyCreation.yml,.github/workflows/testWlsVmAdmin.yml,.github/workflows/testWlsVmCluster.yml,.github/workflows/testWlsVmDynamicCluster.yml: Removed the preflight job and the steps for setting up the PostgreSQL server within the workflows. Instead, these workflows now use thecreatePostgresqlFlexibleServeraction to set up the server. [1] [2] [3] [4] [5] [6] [7] [8]Workflow modification:
.github/workflows/setupWlsAksDependency.yml,.github/workflows/testWlsAksWithDependencyCreation.yml,.github/workflows/testWlsVmAdmin.yml,.github/workflows/testWlsVmCluster.yml,.github/workflows/testWlsVmDynamicCluster.yml: Modified the workflows to use thedbAdminUseranddbServerNameenvironment variables. These variables are used as inputs to thecreatePostgresqlFlexibleServeraction and in the connection string for the database. [1] [2] [3] [4] [5] [6] [7] [8] [9]Environment variable addition:
.github/variables/vm-dependencies.env: Added theazCliVersionenvironment variable. This variable is used in the workflows to specify the version of the Azure CLI to use.