-
-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[editor] Limit more fields (website, menu, social medias, etc...) for some POI types #8212
Conversation
56b8b9e
to
60655a3
Compare
The right solution is to update editor.config |
60655a3
to
eb20b22
Compare
@Jean-BaptisteC It's strange. I test it with restaurant and it appear for haircut. Do I miss something ? EDIT : I found the problem. My mistake ^^. |
c36763b
to
63c161c
Compare
63c161c
to
c4aa57e
Compare
c4aa57e
to
b3b5217
Compare
b3b5217
to
3b56dd7
Compare
@biodranik I've changed the scope of the PR. I've also fixed the fact that, for example, parking lots were displaying fields for social medias in the editor (which doesn't make sense). |
mDetailsBlocks.put(Metadata.MetadataType.FMD_WEBSITE_MENU, websiteMenuBlock); | ||
mDetailsBlocks.put(Metadata.MetadataType.FMD_EMAIL, emailBlock); | ||
mDetailsBlocks.put(Metadata.MetadataType.FMD_CONTACT_FACEBOOK, facebookContactBlock); | ||
mDetailsBlocks.put(Metadata.MetadataType.FMD_CONTACT_INSTAGRAM, instagramContactBlock); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did it work before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@biodranik Do I need to change anything?
android/app/src/main/java/app/organicmaps/editor/EditorFragment.java
Outdated
Show resolved
Hide resolved
41f43b3
to
9bfcd94
Compare
Signed-off-by: Arthur-GYT <a.gayot@posteo.com>
9bfcd94
to
74a01c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Did you test it? Note that debug build of OM uploads data into the dev server, and you need a separate account there:
https://master.apis.dev.openstreetmap.org/
If you need to edit some data from the main OSM server, you can upload it to the dev server using this tool: https://github.com/Zverik/osm_to_sandbox
@Jean-BaptisteC PTAL if you have time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Pixel 6 - Android 14
https://master.apis.dev.openstreetmap.org/node/4349085700
All is in the title ^^.
Related to #8052 (comment)