-
-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ios] Set correct location service activity type for cycling #8220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are opposite to the PR's description. Or I missed something?
Or if we prefer "Other" for bicycle, pedestrian should also be "Other", according to the description .. CLActivityTypeFitness
|
Signed-off-by: Alexander Borsuk <me@alex.bio>
1167706
to
f3f361b
Compare
@vng good point, agree. Updated the PR to drop fitness. @kirylkaveryn documentation says that location updates may be stopped in some conditions. Does our current implementation properly resumes these updates after they have been stopped? Because if not, it may cause #799 |
I'm not sure about this change. Documentation says that
Pausing updates doesn't mean "stopping" - that location is disabled. It means that if you having a rest, location will not be updated until you continue walking/biking. Location always starts updating when a user continues activity. I haven't faced any issues with that. Some articles says that
During the biking and hiking it's usually important to tie to the dedicated path... |
Our users do not walk on Apple-approved paths. They use OSM paths, and often go where there are no any paths ) Pausing is ok to save battery, it is important to restart again though ) Aren't docs say that location updates should be restarted manually?
|
Note that in the current car navigation mode position will be closer to Apple's road network data: