Improve page dialog (user) #8224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diogo Rodrigues <dmfrodrigues2000@gmail.com>
dmfrodrigues
force-pushed
the
improve-page-dialog-user
branch
from
52dac49
to
141a7b3
Compare
Co-authored-by: Alexander Borsuk <170263+biodranik@users.noreply.github.com> Signed-off-by: Diogo Rodrigues <dmfrodrigues2000@gmail.com>
Co-authored-by: Alexander Borsuk <170263+biodranik@users.noreply.github.com> Signed-off-by: Diogo Rodrigues <dmfrodrigues2000@gmail.com>
Co-authored-by: Alexander Borsuk <170263+biodranik@users.noreply.github.com> Signed-off-by: Diogo Rodrigues <dmfrodrigues2000@gmail.com>
Co-authored-by: Alexander Borsuk <170263+biodranik@users.noreply.github.com> Signed-off-by: Diogo Rodrigues <dmfrodrigues2000@gmail.com>
Co-authored-by: Alexander Borsuk <170263+biodranik@users.noreply.github.com> Signed-off-by: Diogo Rodrigues <dmfrodrigues2000@gmail.com>
Co-authored-by: Alexander Borsuk <170263+biodranik@users.noreply.github.com> Signed-off-by: Diogo Rodrigues <dmfrodrigues2000@gmail.com>
Signed-off-by: Diogo Rodrigues <dmfrodrigues2000@gmail.com>
dmfrodrigues
force-pushed
the
improve-page-dialog-user
branch
from
3785fd2
to
795ad45
Compare
biodranik
reviewed
May 22, 2024
Signed-off-by: Diogo Rodrigues <dmfrodrigues2000@gmail.com>
biodranik
approved these changes
May 23, 2024
@biodranik Not at all, the implementation is better (less allocations) and is still understandable. Your feedback is welcome 馃檪 |
kavikhalique
pushed a commit
to kavikhalique/organicmaps
that referenced
this pull request
May 25, 2024
* Improve page dialog user Signed-off-by: Diogo Rodrigues <dmfrodrigues2000@gmail.com> Co-authored-by: Alexander Borsuk <170263+biodranik@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Points 2 and 4 are in preparation to move the page dialog to a panel to the left of the map 馃檪 (which I'll do in a separate PR). This will hopefully make the place page less of a nuisance when one specific place is selected but you still want to explore the surroundings, giving a more intuitive experience that is also consistent with the mobile version (where you can select a place, and then drag the map around to see the surroundings).
@biodranik @Ferenc-