node:fs: add Dirent.path and .parentPath fields

[nektro]

Closes #7358

[Jarred-Sumner]

Thanks for this

A couple comments, but it's close to mergeable.

Needs:

• A test that calls the path getter on a recursive: true fs.promises.readdir about 200 times so if there are race conditions/incorrect memory handling when used concurrently it will crash
• A test that calls the path getter on recursive: false fs.promises.readdir
• A test that calls the path getter on recursive: true readdirSync which checks that the path matches the output of node (or at least a fixture of some kind)

[github-actions]

❌ @nektro, your commit has failing tests :(

💪 4 failing tests Darwin AARCH64

• test/cli/install/bun-install.test.ts 1 failing
• test/cli/install/migration/complex-workspace.test.ts 6 failing
• test/js/bun/http/serve.test.ts 2 failing
• test/js/bun/shell/commands/rm.test.ts 1 failing

💻 4 failing tests Darwin x64

• test/bundler/large_asset_regression.test.ts 1 failing
• test/js/bun/http/serve.test.ts 5 failing
• test/js/bun/net/socket.test.ts 1 failing
• test/js/web/fetch/fetch.tls.test.ts 1 failing

🐧🖥 1 failing tests Linux x64

• test/integration/mysql2/mysql2.test.ts 2 failing

🪟💻 16 failing tests Windows x64 baseline

• test/bundler/large_asset_regression.test.ts 1 failing
• test/cli/install/bun-add.test.ts SIGTERM
• test/cli/install/bun-create.test.ts 2 failing
• test/cli/install/bunx.test.ts 5 failing
• test/cli/install/migration/complex-workspace.test.ts 2 failing
• test/integration/esbuild/esbuild.test.ts 1 failing
• test/integration/next-pages/test/dev-server.test.ts 1 failing
• test/js/bun/http/serve.test.ts 1 failing
• test/js/bun/shell/bunshell.test.ts 1 failing
• test/js/bun/shell/commands/rm.test.ts 1 failing
• test/js/node/dns/node-dns.test.js 2 failing
• test/js/node/http2/node-http2.test.js 1 failing
• test/js/node/process/process.test.js 2 failing
• test/js/node/watch/fs.watchFile.test.ts SIGTERM
• test/js/web/fetch/fetch.tls.test.ts 1 failing
• test/js/web/workers/worker.test.ts 2 failing

🪟💻 13 failing tests Windows x64

• test/cli/install/bunx.test.ts 1 failing
• test/cli/install/migration/complex-workspace.test.ts 1 failing
• test/integration/esbuild/esbuild.test.ts 1 failing
• test/integration/next-pages/test/dev-server.test.ts 1 failing
• test/js/bun/http/serve-body-leak.test.ts 3 failing
• test/js/bun/http/serve.test.ts 2 failing
• test/js/bun/shell/bunshell.test.ts 1 failing
• test/js/bun/shell/leak.test.ts 1 failing
• test/js/node/dns/node-dns.test.js 2 failing
• test/js/node/http2/node-http2.test.js 1 failing
• test/js/node/process/process.test.js 2 failing
• test/js/node/watch/fs.watchFile.test.ts SIGTERM
• test/js/web/workers/worker.test.ts 2 failing

View logs

[Jarred-Sumner]

A couple comments

[Jarred-Sumner]

1 comment

[Jarred-Sumner]

Thank you