Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interface/alert): custom actions to dialog #576

Closed
wants to merge 1 commit into from

Conversation

Tynopia
Copy link

@Tynopia Tynopia commented May 10, 2024

Hello,

I've introduced custom actions for alert dialogs to enhance flexibility in Alert development. With this enhancement, custom actions can be added, and when clicked, the dialog will return the ID of the action.

Additionally, when implementing fully custom actions, it's now possible to disable the confirm button.

image

@Tynopia
Copy link
Author

Tynopia commented May 10, 2024

Documentation: overextended/overextended.github.io#184

@Tynopia
Copy link
Author

Tynopia commented May 10, 2024

@thelindat, I've aligned the custom actions with the cancel button by applying the same styling (mr-3). Is this acceptable to you?

image

@Tynopia
Copy link
Author

Tynopia commented May 29, 2024

@thelindat Is there something why nothing happens here

@Tynopia
Copy link
Author

Tynopia commented Jun 11, 2024

@LukeWasTakenn

@LukeWasTakenn
Copy link
Member

Not what the alert dialog was originally designed for, it's supposed to be a simple yes/no pop up.

@Tynopia
Copy link
Author

Tynopia commented Jun 12, 2024

Not what the alert dialog was originally designed for, it's supposed to be a simple yes/no pop up.

So should I create a new dialog for this?

@LukeWasTakenn
Copy link
Member

no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants