Unobfuscate code, fix memory consumption and update validators #17
Conversation
The code was unnecessarily populating queues, which resulted in high memory consumption over time. I simplified the code so that it does not rely on queues at all and cleaned it up a bit
Old validators weren't working so I updated the links to some currently working ones. They work as bonus external bots that apply extra pressure to the host as they try to validate it
DRipper.py
Outdated
| -p : -port default 80 | ||
| -q : -quiet | ||
| -t : -threads default 135 \033[0m ''') |
There was a problem hiding this comment.
DISREGARD. CLEAR NOW.
Could someone explain, why in README is shown usage of -t 135 when turbo mode is ALWAYS enabled and has value 135. I would consider this default behavior which no need to repeat all the time. Another case, when value is 443, and that is my 2nd question - when can it be? How beneficial it would be?
There was a problem hiding this comment.
I don't know why it was referred to as 'turbo' to begin with, as -t parameter was always for defining the number of threads that would send packets simultaneously. I have no idea why they use numbers 135 and 443, my personal tests show that about 300 would be optimal, but that might depend on hardware and connectivity.
DRipper.py
Outdated
| -s : -server ip | ||
| -p : -port default 80 | ||
| -q : -quiet |
There was a problem hiding this comment.
I think that -q is not really quiet mode. With or without output is the same.
Here is screenshot when -q used. So it's NOT quiet.
Or I don't get something, please explain or extend help info or command code.
There was a problem hiding this comment.
-q changes the logging level of messages from ERROR to INFO. The thing is, it never uses the logger afterward. So yeah, good stuff, it's practically useless currently. I will fix it shortly
There was a problem hiding this comment.
I will fix it shortly
Great, Thanks in advance.
There was a problem hiding this comment.
Done, now with -q only the errors are shown
| `git clone https://github.com/palahsu/DDoS-Ripper` | ||
| `git clone https://github.com/Umbriferous/DDoS-Ripper` |
There was a problem hiding this comment.
@Umbriferous if you consider yourself as additional contributor to this repo then you should NOT commit this change.
But if @palahsu passed maintenance of codebase to you, then OK, but still weird.
There was a problem hiding this comment.
I very much doubt that @palahsu will accept any of my changes, but the old version of ripper has memory leaks, validators that no longer work, issues with logging, etc. I want the link to point to the new version for now, and if the merge ever occurs, the link can be modified back
There was a problem hiding this comment.
@Umbriferous Nik, Nikolaj I assume, could you please confirm that all you do is in favor for Ukraine, at least in this tough moment. :) Пароль?
There was a problem hiding this comment.
Yes, I am from Ukraine and support it wholeheartedly.
Паляниця
|
|
||
| <a href="https://t.me/CyberClans"><img src="https://img.shields.io/badge/Telegram-Group%20Telegram%20Join-blue.svg?logo=telegram"></a> | ||
| example: `python3 DRipper.py -s 0.00.00.00 -p -80 -t 300` |
There was a problem hiding this comment.
@Umbriferous nice, now at least it's reasonable to show another value for -t than 135. Finally.
To indicate that the process has begun, even in quiet mode
|
|
|
Same w
|
|
Yeah, it was never supposed to. It is a common standard to define full arguments with a double dash (eg. --threads or --quiet) or short versions with a single dash (eg. -t or -q) |
|
Yeah, I know, I know. So need to at least change in help section to not mislead people when they will read (if they read) :) |
|
Oh, I see what you mean, will do |
| -s : --server ip | ||
| -p : --port default 80 | ||
| -q : --quiet mode (only log errors) | ||
| -t : --threads default 135 (best within 100-400)\033[0m ''') |
|
@Umbriferous what is ur plan in regards merging? I assume @palahsu will not accept, it's OK. So will u publish some message in Telegram when ur |
|
Ou, btw @Umbriferous I frequently see, people use command like this: And as I dig in code, last free input parameter is NOT expected and NOT taken into consideration. Could you please confirm? |
|
@Andrii-L-DDoSer Yeah, it's useless |
|
btw @Umbriferous tracing looks great now. Reasonable finally. THANKS :) When do u plan inform Telegram about final stable version of |
|
@Umbriferous could you please look to this repo? Looks like there are some newest commits, just wanna be sure whos fork is better so far at the moment. |
Code is no longer obfuscated - you can see what is going on.
Memory leaks fixed - the use of queues wasn't necessary and the whole process was simplified.
The old validators were changed with the currently working ones - half of the packets are not needlessly thrown away anymore!