Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNG Renderer: Font and Text Features #90

Open
wants to merge 9 commits into
base: loren/png-renderer
Choose a base branch
from

Conversation

shawn-mcgee
Copy link
Contributor

@shawn-mcgee shawn-mcgee commented Jul 25, 2020

Fix #74. Font loading still needs some rearranging but it works.
Fix #75. Shrink-to-fit is also working well enough, although we may want to investigate adding some degree of padding to the text (jsPDF did this by default). The current implementation leaves no gaps between text and borders.
image

the implementation works! It definitely needs some cleaning up, but it is functional.
added dirty boolean toggle for testing
@shawn-mcgee shawn-mcgee changed the base branch from master to loren/png-renderer July 25, 2020 01:00
@lorennorman lorennorman changed the title Shawn mcgee/issue 74 PNG Renderer: Font and Text Features Jul 25, 2020
@lorennorman
Copy link
Contributor

Couple things we need:

  • can PNG render all of the built-in PDF fonts+variants?
    • they are: helvetica, courier, times, symbol, zapfdingbats in normal, bold, italic, bolditalic
  • can the installed system fonts be exposed to Paperize? whatever the browser already has access to
  • if we go to render a font but it isn't available, how can we fail gracefully and also explain this to the user?
  • side-by-side renders of PDF and PNG should be as close as possible, can we get them pixel perfect?

@lorennorman lorennorman added this to In progress in PNG Renderer via automation Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
PNG Renderer
  
In progress
Development

Successfully merging this pull request may close these issues.

Font Wrapping/Shrink to Fit Embed a Custom Font into PNG renderer
2 participants