-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PNG Renderer: Font and Text Features #90
Open
shawn-mcgee
wants to merge
9
commits into
loren/png-renderer
Choose a base branch
from
shawn-mcgee/issue-74
base: loren/png-renderer
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the implementation works! It definitely needs some cleaning up, but it is functional.
added dirty boolean toggle for testing
This was
linked to
issues
Jul 25, 2020
lorennorman
changed the title
Shawn mcgee/issue 74
PNG Renderer: Font and Text Features
Jul 25, 2020
Couple things we need:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #74. Font loading still needs some rearranging but it works.
Fix #75. Shrink-to-fit is also working well enough, although we may want to investigate adding some degree of padding to the text (jsPDF did this by default). The current implementation leaves no gaps between text and borders.