-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev documentation #6776
Dev documentation #6776
Conversation
Added Directions to install pipenv and added a few notes for clarification.
Hello @Randy-Blancett, Thank you very much for submitting this PR to us! This is what will happen next:
You'll be hearing from us soon, and thank you again for contributing to our project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks but I’m not sure this clarification is needed (eg ocrmypdf requirement), pipenv is not a requirement, though I agree it’s easier. And the comment about setting debug with export is also not accurate, if it’s in the conf file that’s enough.
Overall, without those changes I’m not sure there’s anything left in this PR?
Also, I’m not necessarily the most expert person wrt the backend dev, so perhaps there’s other thoughts.
That Is fine, just wanted to try to clarify the areas that I had issues with.
|
Yea, looking at this it actually already says "Install prerequisites + pipenv as mentioned..." so again, Im not sure this really clarifies things much. And step 1 may or may not be install pipenv (they may have it installed, use another manager, etc) Thanks again for taking the time anyway. |
Proposed change
Called out installing Pipenv (with directions) as well as added notes about what dependencies to install and how to set Debug.
These are to address a few questions I had when setting up my development environment.
Closes #(issue or discussion)
Type of change
Checklist:
pre-commit
hooks, see documentation.