[Gen 4] change coexistence behavior in wifi connecting or wifi connected states with background BLE low prio activity #2764
Conversation
avtolstoy
force-pushed
the
fix/rtl872x-wifi-ble-coex
branch
from
56caa4a
to
068a1db
Compare
avtolstoy
force-pushed
the
fix/rtl872x-wifi-ble-coex
branch
from
fd27eaf
to
8114b41
Compare
avtolstoy
force-pushed
the
fix/rtl872x-wifi-ble-coex
branch
2 times, most recently
from
dd3bc63
to
06d41b5
Compare
hal/src/rtl872x/rtl_sdk_support.cpp
Outdated
| volatile bool s_wifiConnectionState = false; | ||
| volatile bool s_tdmaSkip = false; | ||
|
|
||
| uint32_t s_coexTable[3] = {0x55555555, 0xaaaa5555, 0xf0ffffff}; |
There was a problem hiding this comment.
0x55555555 == BT > WLAN, 0xaaaa5555 == WLAN high-Priority > BT > WLAN low-Priority
avtolstoy
force-pushed
the
fix/rtl872x-wifi-ble-coex
branch
2 times, most recently
from
62f327c
to
dc777df
Compare
avtolstoy
force-pushed
the
fix/rtl872x-wifi-ble-coex
branch
from
786abef
to
0f0ac7d
Compare
…nd wifi connected states along with ble scans
avtolstoy
force-pushed
the
fix/rtl872x-wifi-ble-coex
branch
from
00120e1
to
a4015f8
Compare
| @@ -1,8 +1,20 @@ | |||
| MAIN_STACK_SIZE = 4096 | |||
|
|
|||
| # # FIXME | |||
There was a problem hiding this comment.
Are these fixed in the prebootloader-part1 makefile below?
There was a problem hiding this comment.
Yes, this should probably be removed.
| configureDeepSleepWakeupSource(config); | ||
| enterDeepSleep(); | ||
| // It should not reach here | ||
| } else { | ||
| SysTick->CTRL &= ~SysTick_CTRL_ENABLE_Msk; |
There was a problem hiding this comment.
This disables systick, which should stop the freertos scheduler from swapping in other tasks? So effectively we stop FreeRTOS at this point? Hibernate will restart, so we dont care about starting the OS again?
| * @param reserved | ||
| * @return int | ||
| */ | ||
| int hal_ble_internal(int type, void* data, size_t size, void* reserved); |
There was a problem hiding this comment.
Just double checking we still want to include this hook. I assume its still useful for testing stuff?
There was a problem hiding this comment.
Yes, let's leave it in, might want to tune things up in runtime.
| #define OS_THREAD_PRIORITY_NETWORK (7) | ||
| #define OS_THREAD_PRIORITY_NETWORK_HIGH (8) | ||
| #define OS_THREAD_PRIORITY_NETWORK (6) | ||
| #define OS_THREAD_PRIORITY_NETWORK_HIGH (7) |
There was a problem hiding this comment.
Do these changes have any effect? Do we know what priority the SDK threads run at? Do we need to take into account their priorities perhaps?
There was a problem hiding this comment.
This is just fixing the general problem: MAC network threads should be below LwIP TCP/IP thread.
| info.end = (uint32_t)&link_prebootloader_wifi_fw_ram_end; | ||
| DCache_CleanInvalidate((uint32_t)&info, sizeof(info)); | ||
| rtl_wifi_fw_resp resp = {}; | ||
| int r = km0_km4_ipc_send_request(KM0_KM4_IPC_CHANNEL_GENERIC, KM0_KM4_IPC_MSG_WIFI_FW_INIT, &info, sizeof(info), [](km0_km4_ipc_msg_t* msg, void* context) -> void { |
There was a problem hiding this comment.
What does the "wifi firmware" actually do? Why does it need to run on KM0?
There was a problem hiding this comment.
It manages low power wifi modes and mainly for our use-case prioritization between wifi and bt slots. Pretty much the main thing it does in simple terms is set up an interrupt at TBTT interval (100ms generally, depends on AP settings) and depending on the coexistence configuration may switch the RF frontend between WiFi and BLE peripheral. Of course it's a bit more complex than simply that.
TODO