WIP feat: use PartySocket when connecting via room.parties
#395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b558fa0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
threepointone
force-pushed
the
rewrite-local-deps
branch
from
00e5b25
to
032787a
Compare
threepointone
force-pushed
the
rewrite-local-deps
branch
from
032787a
to
2d0767e
Compare
threepointone
force-pushed
the
rewrite-local-deps
branch
from
2d0767e
to
689eaa2
Compare
threepointone
force-pushed
the
rewrite-local-deps
branch
from
689eaa2
to
4305bf5
Compare
This uses `PartySocket` when connecting why `room.parties`, which gives you reconnection/buffering logic without any extra effort. Non-breaking change, existing code should still just work.
threepointone
force-pushed
the
rewrite-local-deps
branch
from
4305bf5
to
b558fa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
PartySocketwhen connecting whyroom.parties, which gives you reconnection/buffering logic without any extra effort. Non-breaking change, existing code should still just work.This is currently marked as an external, but we should probably bundle it (here and on the platform) so we can guarantee version. Bit tricky, thinking about it.