Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editorconfig file #952

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

berarma
Copy link
Contributor

@berarma berarma commented Nov 27, 2023

This file can be read by many editors and they adjust their settings to the project.

It makes it easier switching between projects.

.editorconfig Outdated Show resolved Hide resolved
.editorconfig Show resolved Hide resolved
@Baklap4
Copy link
Member

Baklap4 commented Nov 27, 2023

Also we can use https://pre-commit.com/ to force this upon commit for a config see for example: https://github.com/UltraStar-Deluxe/format/blob/main/.pre-commit-config.yaml

@twollgam
Copy link
Contributor

Also we can use https://pre-commit.com/ to force this upon commit for a config see for example: https://github.com/UltraStar-Deluxe/format/blob/main/.pre-commit-config.yaml

Hmm, it is nice but python, so we would get new dependencies on all platforms with nearly zero benefit. I am not convinced. Is there a bash-only solution?

@Baklap4
Copy link
Member

Baklap4 commented Nov 27, 2023

Bash only would be the current open pr i guess

@Baklap4
Copy link
Member

Baklap4 commented Nov 27, 2023

Might be nice to extend the editorconfig with ide specific styles to match them
for C++ Visual Studio 2022 it can be found here: https://learn.microsoft.com/en-us/visualstudio/ide/cpp-editorconfig-properties?view=vs-2019&viewFallbackFrom=vs-2022

IDE's to include: Visual Studio 2022 (windows), XCode (mac), ..... on linux

@berarma
Copy link
Contributor Author

berarma commented Nov 27, 2023

Might be nice to extend the editorconfig with ide specific styles to match them for C++ Visual Studio 2022 it can be found here: https://learn.microsoft.com/en-us/visualstudio/ide/cpp-editorconfig-properties?view=vs-2019&viewFallbackFrom=vs-2022

IDE's to include: Visual Studio 2022 (windows), XCode (mac), ..... on linux

Please, send me the settings. I don't use any of those editors. There's a lot of settings there and I don't know which ones would you want to use. We can also do it later in other PRs.

@Baklap4
Copy link
Member

Baklap4 commented Nov 27, 2023

Might be nice to extend the editorconfig with ide specific styles to match them for C++ Visual Studio 2022 it can be found here: https://learn.microsoft.com/en-us/visualstudio/ide/cpp-editorconfig-properties?view=vs-2019&viewFallbackFrom=vs-2022
IDE's to include: Visual Studio 2022 (windows), XCode (mac), ..... on linux

Please, send me the settings. I don't use any of those editors. There's a lot of settings there and I don't know which ones would you want to use. We can also do it later in other PRs.

Scratch it for now, a lot of ide's only support the basic tabs/endofline stuff not the more style things like braces and spaces between items etc. So this can be skipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants