Added support for Comment and ProvidedBy tags so we can distinguish m… #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ultiple sources of the same song.
Closed
Baklap4
force-pushed
the
feature/commenttag
branch
from
9eefe5b
to
e12cffb
Compare
|
Download the artifacts for this pull request:
This service is provided by nightly.link. These artifacts will expire in 90 days and will not be available for download after that time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduces a new field
PROVIDEDBYThis helps in distinguishing where the mapped file came from and which program made it at which version.
Aside from this
#COMMENTis sometimes used which is now also supportedCloses Issue(s)
None
Motivation
I'm trying to get a couple new standardized fields into the ultrastar format.
This allows hosting websites to add their name to song files whilst creator tools like composer add their specific version and appname.
This way everyone knows where the txt came from and which program is used to create it.
Since the varying sources of which you can download songs from differ in quality this is a nicely added bonus to see where it came from.
Might be a niche for just me, but if everyone opts in it'd make for a way better system and maybe even a newly introduced system which combines all the sources out there.... (that's my endgoal)
Testing
You can test this by adding the following tags:
All tags are opt in. But if everyone plays by the rules every txt will have these fields eventually
The tags are shown within the webserver-ui: Playlist and search screen.
All extra tags are seperated by the
|symbol. And the popup if you click a song also mentions the tags + content if they're there.