-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new option in song screen menu that exits and mark the song broken #978
Conversation
Download the artifacts for this pull request:
This service is provided by nightly.link. These artifacts will expire in 90 days and will not be available for download after that time. |
7d5d1a0
to
c730b9b
Compare
Is this to be reviewed? Or is it still in draft phase? |
the information is stored in the database and can later be used for song filtering
The implementation looks good to me. I would, however, suggest to rename 'Abort' to something more explicitly suggesting that this is 'marking the song as broken'. Don't know if I'm necroing something, but the whole tabs vs spaces, what's the intended style for Performous? And if there is a style, it might be a good idea to (auto?) format all files and get it over with (and at the same time invalidating all PR's if github can't handie this..) |
Any suggestions?
|
You mean indent? There is a PR for rejecting wrong formatted files locally. I think github gives no support server side. But a pipeline could fail for wrong formatted files. |
Edit: Maybe something like: |
What does this PR do?
Add new option in song screen menu that exits and mark the song broken.
The information is stored in the database and can later be used for song filtering
Closes Issue(s)
#942
Motivation
Many songs from usdb are not synchronous so the are not performable. This is the first step to be able to filter out those songs. Later #868 will be extended to apply a filter for broken songs.
Testing
Actually there is nothing that the user can notice after a song is marked. Tests can only prove that the database.xml holds the broken flag.
On Windows the database.xml ist found at
C:\Users\<username>\AppData\Roaming\performous
.