Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stylelint ✨): add support for stylelint 14 #1091

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

manbearwiz
Copy link

BREAKING CHANGE: Requires stylelint@^14, config change

Stylelint removed the configOverrides option. The config passed to stylelint now replaces the configuration loaded from .stylelintrc.

See the Stylelint Migration Guide for details.

BREAKING CHANGE: Requires stylelint@^14, config change

Stylelint removed the `configOverrides` option. The config passed to
stylelint now replaces the configuration loaded from `.stylelintrc`.

See the [`Stylelint Migration
Guide`](https://stylelint.io/migration-guide/to-14/) for details
@manbearwiz
Copy link
Author

If you would prefer to handle this stylelint breaking change another way, please let me know. Stylelint does expose a resolveConfig function to get the config for a file; however, that would mean calling resolveConfig and lint on each file individually.

@phenomnomnominal
Copy link
Owner

Thanks for the PR! The resolveConfig option sounds interesting, I guess that makes it more like how ESLint runs, where different files can have wildly different configs. It could line up with ./packages/eslint/src/eslint.ts quite nicely?

@adrianbruntonsagecom
Copy link

adrianbruntonsagecom commented Mar 15, 2024

Thanks for the PR! The resolveConfig option sounds interesting, I guess that makes it more like how ESLint runs, where different files can have wildly different configs. It could line up with ./packages/eslint/src/eslint.ts quite nicely?

@phenomnomnominal - do you know the status of this pls? Whilst not the current version of stylelint (16.2.1), it seems like this would be a step in the right direction. I've not found any combination of packages that work with the betterer stylelint test and the stylelint configs stylelint-config-standard and stylelint-config-standard-scss which is preventing me from making use of betterer.

If we could work towards using the latest version of stylelint as a peer dependency, that would be ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants