GC : fix issue of delete range could not be executed again if the cleaning rules failed

[ystaticy]

What problem does this PR solve?

If the rules cleaning fails, it should not delete the ranges record from the gc_delete_range table.
Otherwise, it will cause the residue of rules, due to the delete range could not be executed again.

Issue Number: ref #53369

Problem Summary:

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @ystaticy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 56.9645%. Comparing base (2ef3ac9) to head (f9634d0).
Report is 126 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #53368         +/-   ##
=================================================
- Coverage   72.5370%   56.9645%   -15.5726%     
=================================================
  Files          1505       1623        +118     
  Lines        429823     618562     +188739     
=================================================
+ Hits         311781     352361      +40580     
- Misses        98749     243531     +144782     
- Partials      19293      22670       +3377     

Flag	Coverage Δ
integration	39.3653% <0.0000%> (?)
unit	71.4579% <11.1111%> (+0.0269%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9656% <ø> (-1.0302%)	⬇️
parser	∅ <ø> (∅)
br	49.8923% <ø> (+8.4950%)	⬆️

[ystaticy]

/test check-dev2

[tiprow]

@ystaticy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ystaticy]

/test check-dev2

[tiprow]

@ystaticy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, MyonKeminta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MyonKeminta,guo-shaoge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-06-06 03:22:37.90696577 +0000 UTC m=+2911.960277686: ☑️ agreed by guo-shaoge.
• 2024-06-06 04:17:32.250121194 +0000 UTC m=+6206.303433118: ☑️ agreed by MyonKeminta.

[tiprow]

@ystaticy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
fast_test_tiprow	f9634d0	link	true	/test fast_test_tiprow
tidb_parser_test	f9634d0	link	true	/test tidb_parser_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.