Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ApplicationMixins.d.ts #10548

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Update ApplicationMixins.d.ts #10548

wants to merge 1 commit into from

Conversation

blondon1
Copy link

@blondon1 blondon1 commented May 19, 2024

Defined method signatures without the arrow function syntax to maintain consistency with method definitions in interfaces.

Description of change
Pre-Merge Checklist
  • Tests and/or benchmarks are included
  • Documentation is changed or added
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

Defined method signatures without the arrow function syntax to maintain consistency with method definitions in interfaces.
Copy link

korbit-ai bot commented May 19, 2024

My review is in progress 📖 - I will have feedback for you in a few minutes!

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed your code and did not find any issues!


Please note that I can make mistakes, and you should still encourage your team to review your code as well.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e8ddc23:

Sandbox Source
pixi.js-sandbox Configuration

Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Would you mind fixing up the linting? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants