Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move all requires-* to common folder #2842

Merged
merged 5 commits into from
May 31, 2024
Merged

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Apr 30, 2024

This is just a suggestion, and fell free to reject it fro any reason, but I believe this would make the project navigation easier as all requirements files will we grouped in a single folder and not pealing in the root 馃Ι

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • task 1
    • task 2
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

@T4rk1n
Copy link
Contributor

T4rk1n commented May 28, 2024

Sorry it took a long time to review, I couldn't decide if I like this change or not.

On one hand I like to have them easily accessible at the root for ease of use and that way our dependencies are right on the github front page for everyone to see.

But putting them in a subfolder is actually a bit better for completion on the shell and the root is kinda crowded making the requirements files requires scrolling to get to them.

I would just rename the requires folder to requirements to be more like the standard requirements.txt of Python projects then I think we are good with this change.

cc @ndrezn @gvwilson

@gvwilson
Copy link

thanks @T4rk1n - @Borda, are you OK making the suggested change and pushing again?

@Borda
Copy link
Contributor Author

Borda commented May 30, 2024

I couldn't decide if I like this change or not.

that is completely fine :)

I would just rename the requires folder to requirements to be more like the standard requirements.txt of Python projects then I think we are good with this change.

sure, will make it... with requires I tried to be closer to the actual case but tbh, but requirements would be my first/natural choice :)

MANIFEST.in Outdated Show resolved Hide resolved
Co-authored-by: Philippe Duval <t4rk@outlook.com>
Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃拑 Looks good, thank you.

@T4rk1n T4rk1n merged commit 560b230 into plotly:dev May 31, 2024
3 checks passed
@Borda Borda deleted the requires-dir branch May 31, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants