-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move all requires-* to common folder #2842
Conversation
Sorry it took a long time to review, I couldn't decide if I like this change or not. On one hand I like to have them easily accessible at the root for ease of use and that way our dependencies are right on the github front page for everyone to see. But putting them in a subfolder is actually a bit better for completion on the shell and the root is kinda crowded making the requirements files requires scrolling to get to them. I would just rename the |
that is completely fine :)
sure, will make it... with |
Co-authored-by: Philippe Duval <t4rk@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃拑 Looks good, thank you.
This is just a suggestion, and fell free to reject it fro any reason, but I believe this would make the project navigation easier as all requirements files will we grouped in a single folder and not pealing in the root 馃Ι
Contributor Checklist
I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PRoptionals
CHANGELOG.md