Upgrade d3 in plotly.js from v3 to v4 #5833
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add d3.round from v3 - add d3.rebind from v3 - add d3-selection-multi methods to d3 object
- regenerate package-lock.json
|
Just commenting out of curiosity, d3 is now at v7, wouldn't be updating a foundational component of Plotly be more important? |
|
Should this be closed as will not happen? |
No. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An initial attempt to close #424 by upgrading d3 from v3 to v4.
See https://iros.github.io/d3-v4-whats-new/#4 as as v1
d3-*modules for the difference between two versions.Right now half of the baselines successfully pass the image test. 🎉
The other half render with no
console.errorbut mostly fail as a result ofautomarginandlegendstyling.There are also interaction issues that should be addressed.
Tagging @plotly/plotly_js @jonmmease as well as certain gold medalists contributors @etpinard @rreusser @monfera from The Hall of Fame in case they would like to give this better direction. 🙏
https://observablehq.com/@archmoj/plotly-js-recent-pr-branch-chooser/2