-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support .prettierrc.jsonc
#16287
base: main
Are you sure you want to change the base?
Conversation
I think we already support enough formats. Anyway if we want support it, we need a different loader. |
Why would this require a different loader? |
Because our |
Yes. I anticipated that. And it's why I'm using the |
We should NOT load invalid config file. |
Okay. Well, let's get back to this question because it supercedes the loader concern Here's my original justification: It's pretty common but unfortunate practice to name files
It would be nice to allow "json with comments" as a format in common with these tools. Does that align with Prettier's goals? (If not, I'll close this PR outright) If so, would it be sensible to tolerate comments in the |
Description
Support
.prettierrc.jsonc
as a config file.Checklist
docs/
directory).changelog_unreleased/*/XXXX.md
file followingchangelog_unreleased/TEMPLATE.md
.✨Try the playground for this PR✨