Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add policy for PUSH require presence #3936

Merged
merged 13 commits into from
Jun 3, 2024
Merged

Add policy for PUSH require presence #3936

merged 13 commits into from
Jun 3, 2024

Conversation

cornelinux
Copy link
Member

In this implementation a policy defines, that the
user needs to confirm the correct choice, as
displayed in the login UI.

Working on #3897

In this implementation a policy defines, that the
user needs to confirm the correct choice, as
displayed in the login UI.

Working on #3897
@pep8speaks
Copy link

pep8speaks commented May 10, 2024

Hello @cornelinux! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-06-03 13:57:01 UTC

@cornelinux cornelinux marked this pull request as ready for review May 28, 2024 20:51
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 91.17647% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 92.14%. Comparing base (ca819aa) to head (5b790c1).
Report is 28 commits behind head on master.

Current head 5b790c1 differs from pull request most recent head f0f796b

Please upload reports for the commit f0f796b to get more accurate results.

Files Patch % Lines
privacyidea/lib/tokens/pushtoken.py 89.28% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3936      +/-   ##
==========================================
- Coverage   92.25%   92.14%   -0.11%     
==========================================
  Files         196      195       -1     
  Lines       25456    24855     -601     
==========================================
- Hits        23484    22903     -581     
+ Misses       1972     1952      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cornelinux cornelinux linked an issue May 31, 2024 that may be closed by this pull request
9 tasks
@nilsbehlen nilsbehlen merged commit 3d87c8e into master Jun 3, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 person login
4 participants