Add LinodeSD configuration fields to the Scrape Config CRD #6586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurSens
reviewed
May 15, 2024
slashpai
reviewed
May 16, 2024
|
There's a problem with the generated code it seems like, what should we do? |
mviswanathsai
force-pushed
the
add-linodeSDConfig
branch
from
7017c8d
to
a870f06
Compare
|
PS: I will squash the commits once the PR gets approval! |
|
Hmmmm, not sure what's happening here... The |
mviswanathsai
force-pushed
the
add-linodeSDConfig
branch
2 times, most recently
from
3fa4147
to
77eddf3
Compare
|
Can you pull latest changes from main and run generate again. There was API dependencies bump done today looks like failures in generate is due to that. |
mviswanathsai
force-pushed
the
add-linodeSDConfig
branch
2 times, most recently
from
f0d005b
to
34cd7c4
Compare
mviswanathsai
force-pushed
the
add-linodeSDConfig
branch
2 times, most recently
from
ff547c3
to
831e05b
Compare
mviswanathsai
force-pushed
the
add-linodeSDConfig
branch
from
831e05b
to
b95705a
Compare
|
I also added a validation for MinLength for the region field, considering that Prometheus rejects empty string values anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the LinodeSD configuration fields to the ScrapeConfig CRD.
Closes #6579
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.