tsdb: expose hook in tsdb to allow customizing compactor #14113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Ye <benye@amazon.com>
SuperQ
approved these changes
May 25, 2024
|
Can you please take a look? @jesusvazquez Thanks |
|
@codesome plans to do the final review here (but @jesusvazquez you are more than welcome, too, of course). |
codesome
approved these changes
Jun 4, 2024
tsdb/db.go
Outdated
| @@ -189,8 +189,13 @@ type Options struct { | |||
|
|
|||
| // EnableSharding enables query sharding support in TSDB. | |||
| EnableSharding bool | |||
|
|
|||
| // NewCompactorFunc is a function which initializes a TSDB compactor. | |||
There was a problem hiding this comment.
Suggested change
| // NewCompactorFunc is a function which initializes a TSDB compactor. | |
| // NewCompactorFunc is a function that returns a TSDB compactor. | |
| // This overrides the default compactor if set. |
There was a problem hiding this comment.
Thanks! Updated the comment.
Signed-off-by: Ben Ye <benye@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to expose a hook in TSDB to allow downstream projects which uses TSDB as a library to customize their own compactor implementation. If no hook is provided, by default the leveled compactor is used. There is no change for Prometheus project itself.
Also added a test case to cover the usage of the hook.