-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rds): Add RDS certificate expiration check #4002
feat(rds): Add RDS certificate expiration check #4002
Conversation
.../aws/services/rds/rds_instance_certificate_expiration/rds_instance_certificate_expiration.py
Outdated
Show resolved
Hide resolved
.../aws/services/rds/rds_instance_certificate_expiration/rds_instance_certificate_expiration.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @madereddy, I like this check! Please, review my comments 😄
Not sure why pr-lint-test 3.9 failed. I ran the test several times on my machine and it was successful.
|
Reviewed further, synced master branch back into my fork and then rebased this commit in and the PR Lint 3.9 succeeded.
|
@sergargar @jfagoagas Can you rerun the failed lint test? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4002 +/- ##
==========================================
+ Coverage 86.51% 86.64% +0.12%
==========================================
Files 776 777 +1
Lines 24163 24237 +74
==========================================
+ Hits 20904 20999 +95
+ Misses 3259 3238 -21 ☔ View full report in Codecov by Sentry. |
@jfagoagas @sergargar Looking at the codecov report, I see that changes I made have more coverage, but indirectly the ec2 service is going down by about 5.47%. Is there anything I need to do to fix this? |
Hi @madereddy , I have added the case of RDS Certificates that expires in less than a month the check will FAIL with a severity of high. |
Context
Ensure that the SSL/TLS certificates configured for your Amazon RDS are not expired.
Description
Check RDS certificate validity and inform if the certificate will expire soon. Certificate rotation takes coordination between the application and RDS.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.