LibreOffice enablement on Ubuntu Touch #523
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These clear current fontconfig issues with LibreOffice on Ubuntu Touch.
Wrappings for multiple functions used by LibreOffice: - GTK3 - Cairo - libxml2 - GObject
ptitSeb
reviewed
Feb 25, 2023
| @@ -120,6 +120,11 @@ EXPORT void my3_gdk_window_remove_filter(x64emu_t* emu, void* window, void* f, v | |||
| my->gdk_window_remove_filter(window, findFilterFct(f), data); | |||
| } | |||
|
|
|||
| EXPORT unsigned int my3_gdk_threads_add_idle(x64emu_t* emu, void* function, void* data) | |||
| { | |||
| my->gdk_threads_add_idle(function, data); | |||
There was a problem hiding this comment.
You probably want to use a callback tranformation for function. Something like findGSourceFuncFct but you'll have to copy it from wrappedglib2.c first.
ptitSeb
reviewed
Feb 25, 2023
| @@ -250,7 +250,7 @@ GO(xmlCtxtGetLastError, pFp) | |||
| GO(xmlCtxtReadDoc, pFppppi) | |||
| GO(xmlCtxtReadFd, pFpippi) | |||
| GO(xmlCtxtReadFile, pFpppi) | |||
| //GOM(xmlCtxtReadIO, pFEpBBpppi) | |||
| GO(xmlCtxtReadIO, pFppppppi) | |||
There was a problem hiding this comment.
the B in the comented signature means "warning, there is a callBack": so they need special care with a find_XXXX and all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP branch around making LibreOffice x86_64 work on Ubuntu Touch aarch64.
This is part of an effort for my Winebox project which also ships Wine and registers the binfmt_misc handler using systemd.
I feel like I'll stick around with a few contributions every now and then, so stay tuned. :)