Small fixes for RISC-V #2172
Merged
Small fixes for RISC-V #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ordoviz
force-pushed
the
various-fixes-for-nonX64-archs
branch
3 times, most recently
from
3f92b9a
to
9b1c194
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2172 +/- ##
==========================================
+ Coverage 3.65% 58.77% +55.11%
==========================================
Files 196 196
Lines 25383 25725 +342
Branches 2597 2619 +22
==========================================
+ Hits 928 15120 +14192
+ Misses 24327 9781 -14546
- Partials 128 824 +696 ☔ View full report in Codecov by Sentry. |
Ordoviz
force-pushed
the
various-fixes-for-nonX64-archs
branch
from
9b1c194
to
98fba55
Compare
|
@Ordoviz hmm a recent commit made conflicts here. Can you resolve them? @OBarronCS Can you help review this? |
pwndbg-git from AUR shows hexadecimal constants in masm syntax (e.g. 80h) for some reason (as if the option CS_OPT_SYNTAX_MASM was set). This commit makes syscall name printing work regardless of hex syntax.
When the PC was on this instruction, the pwndbg context would not be printed due to this AssertionError.
According to the specification, "C.JALR expands to jalr x1, 0(rs1)".
Ordoviz
force-pushed
the
various-fixes-for-nonX64-archs
branch
from
98fba55
to
d756557
Compare
|
Actually, lgtm, merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.