-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hg-bigbird-ci-failure] Change fail_accuracy to fail_to_run for export #126591
Conversation
[ghstack-poisoned]
ghstack-source-id: c6845bffa4a4b668cd1f5e9b85b459c024ce9497 Pull Request resolved: #126591
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126591
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 89b812d with merge base 93844a3 (): FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…n for export" I don't really know what made hf_Bigbird pass for export earlier, but it should never have. The model uses `numpy` in between the pytorch operations to introduce randomness. [ghstack-poisoned]
ghstack-source-id: aef5438fdddac2727d4144712b51716886af1485 Pull Request resolved: #126591
@@ -138,7 +138,7 @@ hf_Bert_large,pass,0 | |||
|
|||
|
|||
|
|||
hf_BigBird,fail_accuracy,0 | |||
hf_BigBird,fail_to_run,0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It fails to run because this is export. So, fails_to_run is an improvement.
@@ -150,7 +150,7 @@ hf_Bert_large,pass,0 | |||
|
|||
|
|||
|
|||
hf_BigBird,fail_to_run,0 | |||
hf_BigBird,pass,46 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely an improvement.
@@ -150,7 +150,7 @@ hf_Bert_large,pass,0 | |||
|
|||
|
|||
|
|||
hf_BigBird,fail_to_run,0 | |||
hf_BigBird,fail_accuracy,46 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mehh ... not sure what category this is, but baseline is bad anyways.
…n for export" I don't really know what made hf_Bigbird pass earlier, but it should never have. The model uses `numpy` in between the pytorch operations to introduce randomness. So it should have graph breaks. So, this is actually an IMPROVEMENT. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]
ghstack-source-id: d53c9aa905965bb85442e64aa8080a2c63e68fe1 Pull Request resolved: #126591
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: Command
Details for Dev Infra teamRaised by workflow job |
Done at #126414 |
Stack from ghstack (oldest at bottom):
I don't really know what made hf_Bigbird pass earlier, but it should never have. The model uses
numpy
in between the pytorch operations to introduce randomness. So it should have graph breaks. So, this is actually an IMPROVEMENT.cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang