don't check memory format for empty tensors #126593
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126593
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ddf47c9 with merge base aa6de76 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced May 18, 2024
ezyang
approved these changes
May 19, 2024
Fix #125967 . The test actually fail for empty 4D or 5D tensors when checking for memory format. I'm not exactly sure what recent inductor change cause the failure, but it may be not that important to maintain strides for an empty tensor. (?) I just skip the check for empty tensor. [ghstack-poisoned]
Fix #125967 . The test actually fail for empty 4D or 5D tensors when checking for memory format. I'm not exactly sure what recent inductor change cause the failure, but it may be not that important to maintain strides for an empty tensor. (?) I just skip the check for empty tensor. [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
May 22, 2024
pytorchmergebot
added a commit
that referenced
this pull request
May 23, 2024
This reverts commit 12dee4f. Reverted #126593 on behalf of https://github.com/clee2000 due to broke tests on inductor? test_modules.py::TestModuleCUDA::test_cpu_gpu_parity_nn_CTCLoss_cuda_float64 https://hud.pytorch.org/pytorch/pytorch/commit/43f2f43eb3b6d8cbe8eb7f45acb50376092f1a16 https://github.com/pytorch/pytorch/actions/runs/9200644034/job/25308511495 ([comment](#126586 (comment)))
|
@shunting314 your PR has been successfully reverted. |
Fix #125967 . The test actually fail for empty 4D or 5D tensors when checking for memory format. I'm not exactly sure what recent inductor change cause the failure, but it may be not that important to maintain strides for an empty tensor. (?) I just skip the check for empty tensor. [ghstack-poisoned]
shunting314
added a commit
that referenced
this pull request
May 24, 2024
ghstack-source-id: 4ad57b6e41ae49cfe2fb0649c9145c1b92e361a0 Pull Request resolved: #126593
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
May 25, 2024
…#126594) This reverts commit 0a9c6e9. enable the test since it's fixed. Pull Request resolved: #126594 Approved by: https://github.com/huydhn ghstack dependencies: #126593
pragupta
pushed a commit
to pragupta/pytorch
that referenced
this pull request
May 28, 2024
Fix pytorch#125967 . The test actually fail for empty 4D or 5D tensors when checking for memory format. I'm not exactly sure what recent inductor change cause the failure, but it may be not that important to maintain strides for an empty tensor. (?) I just skip the check for empty tensor. Pull Request resolved: pytorch#126593 Approved by: https://github.com/ezyang
titaiwangms
pushed a commit
to titaiwangms/pytorch
that referenced
this pull request
May 28, 2024
Fix pytorch#125967 . The test actually fail for empty 4D or 5D tensors when checking for memory format. I'm not exactly sure what recent inductor change cause the failure, but it may be not that important to maintain strides for an empty tensor. (?) I just skip the check for empty tensor. Pull Request resolved: pytorch#126593 Approved by: https://github.com/ezyang
titaiwangms
pushed a commit
to titaiwangms/pytorch
that referenced
this pull request
May 28, 2024
…25970)" (pytorch#126594) This reverts commit 0a9c6e9. enable the test since it's fixed. Pull Request resolved: pytorch#126594 Approved by: https://github.com/huydhn ghstack dependencies: pytorch#126593
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
May 29, 2024
Fix pytorch#125967 . The test actually fail for empty 4D or 5D tensors when checking for memory format. I'm not exactly sure what recent inductor change cause the failure, but it may be not that important to maintain strides for an empty tensor. (?) I just skip the check for empty tensor. Pull Request resolved: pytorch#126593 Approved by: https://github.com/ezyang Co-authored-by: Shunting Zhang <shunting@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fix #125967 . The test actually fail for empty 4D or 5D tensors when checking for memory format.
I'm not exactly sure what recent inductor change cause the failure, but it may be not that important to maintain strides for an empty tensor. (?)
I just skip the check for empty tensor.