New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fb_memcache: change fb internal memcache location #126603

Closed

c00w wants to merge 1 commit into pytorch:main from c00w:export-D57516213

c00w commented May 18, 2024 •

edited by pytorch-bot bot

Summary: The fb_memcache injections location and path is changing.

Test Plan: This shouldn't be capable of failing any tests on github.

Differential Revision: D57516213

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang

pytorch-bot bot commented May 18, 2024

This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @c00w, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team.

linux-foundation-easycla bot commented May 18, 2024 •

edited

The committers listed above are authorized under a signed CLA.

✅ login: c00w / name: Colin (c319753)

pytorch-bot bot added the module: inductor label

pytorch-bot bot commented May 18, 2024 •

edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126603

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 4 Unrelated Failures

As of commit c319753 with merge base e3db9ba ():

NEW FAILURE - The following job has failed:

Lint / lintrunner-noclang / linux-job (gh)
>>> Lint for torch/_inductor/runtime/triton_heuristics.py:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 1, 5, linux.g5.4xlarge.nvidia.gpu) (gh) (similar failure)
inductor/test_max_autotune.py::TestMaxAutotune::test_max_autotune_remote_caching_dynamic_False

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

inductor / cuda12.1-py3.10-gcc9-sm86 / test (inductor, 1, 1, linux.g5.4xlarge.nvidia.gpu) (gh) (trunk failure)
test_modules.py::TestModuleCUDA::test_cpu_gpu_parity_nn_CTCLoss_cuda_float64
inductor / cuda12.1-py3.12-gcc9-sm86 / test (inductor, 1, 1, linux.g5.4xlarge.nvidia.gpu) (gh) (trunk failure)
test_modules.py::TestModuleCUDA::test_cpu_gpu_parity_nn_CTCLoss_cuda_float64
inductor / rocm6.1-py3.8-inductor / test (inductor, 1, 1, linux.rocm.gpu.2) (gh) (trunk failure)
test_modules.py::TestModuleCUDA::test_cpu_gpu_parity_nn_CTCLoss_cuda_float64

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Contributor

facebook-github-bot commented May 18, 2024

This pull request was exported from Phabricator. Differential Revision: D57516213

facebook-github-bot added the fb-exported label

oulgen approved these changes

View reviewed changes

Contributor

oulgen left a comment

OSS parts of the code looks good to me, I left additional feedback on the Fbcode side.

pytorch-bot bot commented May 18, 2024

This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @c00w, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team.

c00w force-pushed the export-D57516213 branch from 6c77f72 to fa92c9c Compare

May 21, 2024 09:41

Contributor

facebook-github-bot commented May 21, 2024

This pull request was exported from Phabricator. Differential Revision: D57516213

pytorch-bot bot added the ciflow/inductor label

c00w added a commit to c00w/pytorch that referenced this pull request


          fb_memcache: change fb internal memcache location (pytorch#126603)

fa92c9c

Summary:
Pull Request resolved: pytorch#126603

The fb_memcache injections location and path is changing.

Test Plan: This shouldn't be capable of failing any tests on github.

Reviewed By: bertmaher

Differential Revision: D57516213

Contributor

facebook-github-bot commented May 21, 2024

This pull request was exported from Phabricator. Differential Revision: D57516213

c00w added a commit to c00w/pytorch that referenced this pull request


          fb_memcache: change fb internal memcache location (pytorch#126603)

8e96e15

Summary:
Pull Request resolved: pytorch#126603

The fb_memcache injections location and path is changing.

Test Plan: This shouldn't be capable of failing any tests on github.

Reviewed By: bertmaher

Differential Revision: D57516213

c00w force-pushed the export-D57516213 branch from fa92c9c to 8e96e15 Compare

May 21, 2024 10:42

Contributor

facebook-github-bot commented May 21, 2024

This pull request was exported from Phabricator. Differential Revision: D57516213

c00w force-pushed the export-D57516213 branch from 8e96e15 to c7cfcfb Compare

May 21, 2024 14:46

c00w added a commit to c00w/pytorch that referenced this pull request


          fb_memcache: change fb internal memcache location (pytorch#126603)

c7cfcfb

Summary:
Pull Request resolved: pytorch#126603

The fb_memcache injections location and path is changing.

Test Plan: This shouldn't be capable of failing any tests on github.

Reviewed By: bertmaher

Differential Revision: D57516213


          fb_memcache: change fb internal memcache location (pytorch#126603)

c319753

Summary:
Pull Request resolved: pytorch#126603

The fb_memcache injections location and path is changing.

Test Plan: This shouldn't be capable of failing any tests on github.

Reviewed By: bertmaher

Differential Revision: D57516213

Contributor

facebook-github-bot commented May 22, 2024

This pull request was exported from Phabricator. Differential Revision: D57516213

c00w force-pushed the export-D57516213 branch from c7cfcfb to c319753 Compare

May 22, 2024 23:53

Contributor

facebook-github-bot commented May 25, 2024

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorch-bot bot added the ciflow/trunk label

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented May 25, 2024

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team

Raised by workflow job

pytorchmergebot removed the merging label

DanilBaibak added the topic: not user facing label

Contributor

DanilBaibak commented May 27, 2024

@pytorchbot merge

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented May 27, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Collaborator

pytorchmergebot commented May 27, 2024

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Lint / lintrunner-noclang / linux-job

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

pytorchmergebot removed the merging label

DanilBaibak closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment