Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace torch.library.impl_abstract with torch.library.register_fake #126606

Closed
wants to merge 1 commit into from
Closed

Replace torch.library.impl_abstract with torch.library.register_fake #126606

wants to merge 1 commit into from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented May 18, 2024 •
edited by pytorch-bot bot

To remove the disrupting warning

      warnings.warn("torch.library.impl_abstract was renamed to "                                                                                                     
                    "torch.library.register_fake. Please use that instead; "                                                                                          
                    "we will remove torch.library.impl_abstract in a future "                                                                                         
                    "version of PyTorch.",                                                                                                                            
                    DeprecationWarning, stacklevel=2)

cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang @d4l3k

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 18, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126606

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 018da73 with merge base a44d0cf (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever marked this pull request as draft May 18, 2024 02:24
@cyyever cyyever changed the title Deprecation may Replace torch.library.impl_abstract with torch.library.register_fake May 18, 2024
@cyyever cyyever requested a review from zou3519 May 18, 2024 03:50
@cyyever cyyever marked this pull request as ready for review May 18, 2024 06:31
@cyyever cyyever requested a review from ezyang May 18, 2024 23:15
@cyyever cyyever added topic: deprecation topic category ciflow/trunk Trigger trunk jobs on your pull request labels May 18, 2024
@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: onnx torch.onnx related changes that should show up in the release notes labels May 18, 2024
@ezyang
Copy link
Contributor

ezyang commented May 19, 2024

@pytorchbot merge

@ezyang ezyang added the topic: not user facing topic category label May 19, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / win-vs2019-cpu-py3 / test (default, 1, 3, windows.4xlarge.nonephemeral)

Details for Dev Infra team Raised by workflow job

@cyyever
Copy link
Collaborator Author

cyyever commented May 19, 2024

@pytorchmergebot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / win-vs2019-cpu-py3 / test (default, 1, 3, windows.4xlarge.nonephemeral)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ZelboK pushed a commit to ZelboK/pytorch that referenced this pull request May 19, 2024
@cyyever @ZelboK
Replace torch.library.impl_abstract with torch.library.register_fake (p…
454d0d4 
…ytorch#126606)

To remove the disrupting warning
```
      warnings.warn("torch.library.impl_abstract was renamed to "
                    "torch.library.register_fake. Please use that instead; "
                    "we will remove torch.library.impl_abstract in a future "
                    "version of PyTorch.",
                    DeprecationWarning, stacklevel=2)
```

Pull Request resolved: pytorch#126606
Approved by: https://github.com/ezyang
@cyyever cyyever deleted the deprecation_may branch May 23, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@zou3519 zou3519 Awaiting requested review from zou3519 zou3519 is a code owner

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan tugsbayasgalan is a code owner

@ydwu4 ydwu4 Awaiting requested review from ydwu4 ydwu4 is a code owner

@BowenBao BowenBao Awaiting requested review from BowenBao BowenBao is a code owner

@thiagocrepaldi thiagocrepaldi Awaiting requested review from thiagocrepaldi thiagocrepaldi is a code owner

@wschin wschin Awaiting requested review from wschin wschin is a code owner

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: deprecation topic category topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cyyever @ezyang @pytorchmergebot @pytorchbot