-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typing scheduler.py [1/3]: Add NodeSchedulerNode #126609
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced May 18, 2024
aorenste
changed the title
Add NodeSchedulerNode
typing scheduler.py [2/4]: Add NodeSchedulerNode
May 18, 2024
Split off to make reviewing easier. `BaseSchedulerNode` really represents two types of nodes - ones where the `node` field is valid (most of them) and ones where the `node` field isn't (ones derived from `FusedSchedulerNode`). In the `FusedSchedulerNode` case we also don't want to run `BaseSchedulerNode`'s `__init__`. `FusedSchedulerNode` also overrides a bunch of methods to throw `NotImplementedError`. Add a new class, `NodeSchedulerNode` to represent nodes where `node` is valid and move the methods that `FusedSchedulerNode` doesn't care about onto it. No actual code changes - just moving methods around. [ghstack-poisoned]
Split off to make reviewing easier. `BaseSchedulerNode` really represents two types of nodes - ones where the `node` field is valid (most of them) and ones where the `node` field isn't (ones derived from `FusedSchedulerNode`). In the `FusedSchedulerNode` case we also don't want to run `BaseSchedulerNode`'s `__init__`. `FusedSchedulerNode` also overrides a bunch of methods to throw `NotImplementedError`. Add a new class, `NodeSchedulerNode` to represent nodes where `node` is valid and move the methods that `FusedSchedulerNode` doesn't care about onto it. No actual code changes - just moving methods around. [ghstack-poisoned]
Split off to make reviewing easier. `BaseSchedulerNode` really represents two types of nodes - ones where the `node` field is valid (most of them) and ones where the `node` field isn't (ones derived from `FusedSchedulerNode`). In the `FusedSchedulerNode` case we also don't want to run `BaseSchedulerNode`'s `__init__`. `FusedSchedulerNode` also overrides a bunch of methods to throw `NotImplementedError`. Add a new class, `NodeSchedulerNode` to represent nodes where `node` is valid and move the methods that `FusedSchedulerNode` doesn't care about onto it. No actual code changes - just moving methods around. [ghstack-poisoned]
aorenste
changed the title
typing scheduler.py [2/4]: Add NodeSchedulerNode
typing scheduler.py [1/3]: Add NodeSchedulerNode
May 18, 2024
Split off to make reviewing easier. `BaseSchedulerNode` really represents two types of nodes - ones where the `node` field is valid (most of them) and ones where the `node` field isn't (ones derived from `FusedSchedulerNode`). In the `FusedSchedulerNode` case we also don't want to run `BaseSchedulerNode`'s `__init__`. `FusedSchedulerNode` also overrides a bunch of methods to throw `NotImplementedError`. Add a new class, `NodeSchedulerNode` to represent nodes where `node` is valid and move the methods that `FusedSchedulerNode` doesn't care about onto it. No actual code changes - just moving methods around. [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off to make reviewing easier.
BaseSchedulerNode
really represents two types of nodes - ones where thenode
field is valid (most of them) and ones where thenode
field isn't (ones derived fromFusedSchedulerNode
). In theFusedSchedulerNode
case we also don't want to runBaseSchedulerNode
's__init__
.FusedSchedulerNode
also overrides a bunch of methods to throwNotImplementedError
.Add a new class,
NodeSchedulerNode
to represent nodes wherenode
is valid and move the methods thatFusedSchedulerNode
doesn't care about onto it.No actual code changes - just moving methods around.
Stack from ghstack (oldest at bottom):