Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flexattention not realizing inputs before lowering (also refactored runtime estimation) #126615

Closed
wants to merge 11 commits into from

Conversation

Copy link

pytorch-bot bot commented May 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126615

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 9 Unrelated Failures

As of commit 097ff9c with merge base 7dae7d3 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
@Chillee Chillee requested a review from drisspg May 19, 2024 08:35
@Chillee Chillee added the ciflow/trunk Trigger trunk jobs on your pull request label May 19, 2024
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
@Chillee Chillee changed the title Fix flexattention not realizing inputs before lowering Fix flexattention not realizing inputs before lowering (also refactored runtime estimation) May 19, 2024
@Chillee Chillee requested a review from xmfan May 19, 2024 20:23
…so refactored runtime estimation)"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
…so refactored runtime estimation)"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
@albanD albanD removed their request for review May 20, 2024 14:31
Copy link
Contributor

@drisspg drisspg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flex changes look good, the other looks like a lot of code motion

Copy link
Member

@xmfan xmfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we cleanup the now unused globals from torch/_inductor/metrics.py and in reset()

@Chillee Chillee added the topic: not user facing topic category label May 20, 2024
pytorchmergebot pushed a commit that referenced this pull request May 20, 2024
pytorchmergebot pushed a commit that referenced this pull request May 20, 2024
@DanilBaibak
Copy link
Contributor

@pytorchbot revert -m "Break internal build" -c ghfirst

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request May 22, 2024
This reverts commit cd3a71f.

Reverted #126641 on behalf of https://github.com/DanilBaibak due to Break internal build ([comment](#126615 (comment)))
pytorchmergebot added a commit that referenced this pull request May 22, 2024
This reverts commit da2292c.

Reverted #126446 on behalf of https://github.com/DanilBaibak due to Break internal build ([comment](#126615 (comment)))
pytorchmergebot added a commit that referenced this pull request May 22, 2024
…refactored runtime estimation) (#126615)"

This reverts commit 831efee.

Reverted #126615 on behalf of https://github.com/DanilBaibak due to Break internal build ([comment](#126615 (comment)))
@pytorchmergebot
Copy link
Collaborator

@Chillee your PR has been successfully reverted.

@DanilBaibak
Copy link
Contributor

Hi @Chillee! Sorry, I need to revert your PR because it breaks the internal a lot of inductor tests (triton_kernels and pattern_matcher). Here you can find more information about the issues - D57619189.

…so refactored runtime estimation)"

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request May 22, 2024
pytorchmergebot pushed a commit that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants