Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added detection target types to Oxford III Pet dataset #8425

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

matlabninja
Copy link
Contributor

Added the detection and binary-detection target types to the Oxford III pet data set loader as discussed in #8364

The dataset loader will load bounding box annotations in the format expected by torchvision's faster RCNN network. It will also filter out images that exist in the dataset that do not include bounding box annotations when one of the detection types is selected. A message is printed to the console indicating that some images are filtered in this case.

Demonstration of the functionality of the detection target types can be found here and here.

Looking for feedback on 2 things:

  1. Given that some images have to be filtered out for this to work, is a simple print statement the best way to notify users?
  2. Given that the _to_rcnn function should work with any dataset using VOC-style detection labels, should we move it to the VOC loader and import it instead of defining it here?

Copy link

pytorch-bot bot commented May 16, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8425

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants