Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow clicks through version ribbon's span #154

Merged
merged 1 commit into from
Dec 6, 2020
Merged

Allow clicks through version ribbon's span #154

merged 1 commit into from
Dec 6, 2020

Conversation

Poopooracoocoo
Copy link
Contributor

ahah! so you use pointer events!

ahah! so you use pointer events!
@Chocobo1
Copy link
Member

Chocobo1 commented Dec 5, 2020

Can you explain what does it do? I tested it but didn't found anything different.

I see you mentioned the problem in #149:

When I tried making the header image fit the width for smaller widths, the height would shrink and the ribbon took up the same amount of space while the menu moved up. This meant that the first few menu items couldn't be accessed! I solved this by making the height stay the same. It could've been solved by changing the ribbon so that clicks go through as there's enough space. https://github.com/simonwhitaker/github-fork-ribbon-css does it better than https://github.com/codepo8/css-fork-on-github-ribbon IMO, but I'm sure there's a way to fix up the current one. Edit: Fixed it with pointer-events!

@Poopooracoocoo
Copy link
Contributor Author

Poopooracoocoo commented Dec 5, 2020

This isn't necessary but is a better foundation, per se. As in it doesn't fix anything right now but any further modifications could potentially benefit, I suppose. ¯\_(ツ)_/¯

@Chocobo1 Chocobo1 merged commit 878c05d into qbittorrent:master Dec 6, 2020
@Chocobo1
Copy link
Member

Chocobo1 commented Dec 6, 2020

@Poopooracoocoo
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants